fix(github-actions): consider previous path for renamed files - #3979
Merged
alan-agius4 merged 4 commits intoSep 17, 2026
Merged
Conversation
canbolayir
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Actions workflows to properly handle renamed files. Specifically, it ensures that both the current and previous filenames of renamed files are evaluated when checking if a change affects Google internal tests and when applying path-based labels to pull requests. A unit test has also been added to verify this behavior. As there are no review comments, I have no feedback to provide.
alan-agius4
added
action: merge
angular-robot
Bot
added
the
area: build & ci
canbolayir
force-pushed
the
fix/rename-path-classification
branch
from
September 17, 2026 15:19
e245e32 to
735a141
Compare
alan-agius4
added
action: merge
alan-agius4
approved these changes
Sep 17, 2026
Contributor
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3976.
GitHub exposes both filename and previous_filename for renamed pull request files. The Google-internal test classifier and pull-request path labeler currently inspect only filename, so moving a file out of a matched path can cause the source-side change to be missed.
This change:
checks both the destination and previous path for renamed files in google-internal-tests;
includes both paths in pull-request path-based labeling; and
adds regression coverage for a rename out of packages/core/primitives/** still receiving requires: TGP.
This follows the maintainer guidance in #3976 to recognize both sides of a rename for synced/sensitive paths.